-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 81.66% 81.74% +0.07%
==========================================
Files 677 687 +10
Lines 8766 8804 +38
Branches 1492 1558 +66
==========================================
+ Hits 7159 7197 +38
Misses 1592 1592
Partials 15 15
Continue to review full report at Codecov.
|
I would prefer if we let the user know if something is not supported. I spent quite some time trying to debug why an icon outline wouldn't render, before realizing it wasn't supported. Generally, I recommend never to fail silently. |
Are we talking a programattic way to indicate that the icon shouldn't have an outlined version? I think it wouldu be sufficient to just have a comment to that effect in the icon itself.
What are the implications of the non-standard viewbox? |
@@ -8,4 +8,5 @@ export default { | |||
</svg> | |||
), | |||
styles: {}, | |||
exportedAs: 'word word-color', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be better to use comma as separator here - then it would be clear that there are two icons exported for that, and that it is not just a single icon exported under word word-color
name
|
There are some cases where you won't want to scale the icon, because while you want the icon to be larger or smaller, you wouldn't necessarily want the paths to show differently. In those cases, design has provided icons for the different sizes. |
Future plan is to export each icon separately. That way each icon can specify which props it can use, outline/filled/size/etc. There is a separate issue for that work. |
Adding the Office icons. In a future task, the idea is to have each icon be exported, so we can specify what props are supported (eg outline, color, sizes).
When that work is completed, we will need to update the [office name]-color icons to indicate they are only supported at 32px size and keep their brand colors. The [office name] icons will need to specify they don't support outline prop too.
New icons: Word, Excel, Powerpoint, Onenote
How to use
<Icon name="word" />
<Icon name="word-color" size="larger" />
Usages in the doc examples
Attachment
Menu